Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert 3 dots and change flex styles #8909

Merged
merged 2 commits into from
May 10, 2022
Merged

Conversation

chiragsalian
Copy link
Contributor

Details

Reverts my first test PR #8906 where i remove those buttons.
Now im attempting to change some styles to see if it helps.

Fixed Issues

#8791

Tests

None, can only be tested on staging and i'll test it.

@chiragsalian chiragsalian self-assigned this May 10, 2022
@chiragsalian chiragsalian requested a review from a team as a code owner May 10, 2022 01:06
@chiragsalian chiragsalian changed the title Revert 3dots change styles Revert 3 dots and change flex styles May 10, 2022
@melvin-bot melvin-bot bot removed the request for review from a team May 10, 2022 01:06
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@melvin-bot melvin-bot bot requested a review from madmax330 May 10, 2022 01:06
@francoisl francoisl merged commit 1a772e1 into main May 10, 2022
@francoisl francoisl deleted the chirga-revert-3dots-change-styles branch May 10, 2022 01:13
OSBotify pushed a commit that referenced this pull request May 10, 2022
…yles

Revert 3 dots and change flex styles

(cherry picked from commit 1a772e1)
OSBotify added a commit that referenced this pull request May 10, 2022
@chiragsalian
Copy link
Contributor Author

That didn't unfortunately didn't work either. Same state as mentioned here - #8906 (comment).

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @francoisl in version: 1.1.57-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @chiragsalian in version: 1.1.57-17 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants