Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add story for InlineSystemMessage #9198

Merged
merged 2 commits into from
May 27, 2022
Merged

Add story for InlineSystemMessage #9198

merged 2 commits into from
May 27, 2022

Conversation

roryabraham
Copy link
Contributor

@roryabraham roryabraham commented May 27, 2022 •
edited
Loading

@Gonals will you please review this?

Details

This PR does two things:

  • Uses theme instead of color for an icon color
  • Adds a storybook story for the InlineSystemMessage component.

Fixed Issues

$ n/a

Tests

  1. Run npm run storybook
  2. Look at the new story:

image

@roryabraham roryabraham requested a review from Gonals May 27, 2022 00:17
@roryabraham roryabraham self-assigned this May 27, 2022
@roryabraham roryabraham requested a review from a team as a code owner May 27, 2022 00:17
@melvin-bot melvin-bot bot requested review from thienlnam and removed request for a team May 27, 2022 00:17
@roryabraham roryabraham mentioned this pull request May 27, 2022
Merged
Luke9389
Luke9389 approved these changes May 27, 2022
View reviewed changes
Copy link
Contributor

@Luke9389 Luke9389 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@Gonals Gonals merged commit 3780ccd into main May 27, 2022
@Gonals Gonals deleted the Rory-CleanupInlineSystemMessage branch May 27, 2022 08:01
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request May 30, 2022
Closed
22 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Gonals in version: 1.1.69-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @luacmartins in version: 1.1.69-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gonals Gonals Gonals approved these changes

@thienlnam thienlnam thienlnam approved these changes

@Luke9389 Luke9389 Luke9389 approved these changes

Assignees

@roryabraham roryabraham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@roryabraham @OSBotify @Gonals @thienlnam @Luke9389