-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove isChunked since no longer used #9381
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now 👍
Tested on web & desktop - so far 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@rushatgabhane sorry I merged this before you were done testing. Feel free to post on here with the results of your testing |
@roryabraham that's no problem :) Here are the tests that I did. Web and desktop - close the laptop lid.
Works well in all cases. |
…herSubscribe (cherry picked from commit 9d4633a)
…9381 🍒 Cherry pick PR #9381 to staging 🍒
🚀 Cherry-picked to staging by @roryabraham in version: 1.1.75-1 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by @roryabraham in version: 1.1.75-1 🚀
|
Details
Looks like we missed removing this after we stopped supporting
isChunked
inPusher.Subscribe
Fixed Issues
$ https://expensify.slack.com/archives/C01GTK53T8Q/p1654799564120799?thread_ts=1654795218.684169&cid=C01GTK53T8Q
Possibly will fix: #9382
Tests
Send messages back 'n forth, make sure they're showing up instantly
Verify that no errors appear in the JS console
PR Review Checklist
Contributor (PR Author) Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)PR Reviewer Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
).src/languages/*
filesSTYLE.md
) were followed/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)QA Steps
Web and desktop - close the laptop lid.
On native - two tests.
Make sure you can send & receive messages live (without refresh) in all cases.
Screenshots
Web
Mobile Web
Desktop
iOS
Android