Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] Create composite action to set up git for OSBotify #9619

Merged
merged 3 commits into from
Jun 30, 2022
Merged

[No QA] Create composite action to set up git for OSBotify #9619

merged 3 commits into from
Jun 30, 2022

Conversation

roryabraham
Copy link
Contributor

@roryabraham roryabraham commented Jun 28, 2022 •
edited
Loading

Details

Creates a composite action to set up git for OSBotify to DRY up some of our workflows.

Fixed Issues

n/a – just DRYing things up and laying groundwork for other composite actions

  • Verify that no errors appear in the JS console

Tests

  1. Merge this PR with the CP Staging label
  2. Verify that the PR is successfully deployed and the automated PR is created by OSBotify with signed commits, as usual.

@roryabraham roryabraham self-assigned this Jun 28, 2022
@roryabraham roryabraham changed the title [HOLD] Create composite action to set up git for OSBotify Create composite action to set up git for OSBotify Jun 30, 2022
@roryabraham roryabraham marked this pull request as ready for review June 30, 2022 21:28
@roryabraham roryabraham requested a review from a team as a code owner June 30, 2022 21:28
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@melvin-bot melvin-bot bot requested review from NikkiWines and removed request for a team June 30, 2022 21:29
@roryabraham roryabraham mentioned this pull request Jun 30, 2022
Merged
NikkiWines
NikkiWines approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@NikkiWines NikkiWines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

.github/actions/composite/setupGitForOSBotify/action.yml
steps:
- name: Decrypt OSBotify GPG key
run: cd .github/workflows && gpg --quiet --batch --yes --decrypt --passphrase=${{ inputs.GPG_PASSPHRASE }} --output OSBotify-private-key.asc OSBotify-private-key.asc.gpg
shell: bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NAB: move this about run: for consistency

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hate how we have to pass shell every time. There's an open PR to add a default shell in composite actions, I commented in there hoping it might get pushed forward 🙂

@NikkiWines NikkiWines merged commit cc37166 into main Jun 30, 2022
@NikkiWines NikkiWines deleted the Rory-SetupGitForOSBotify branch June 30, 2022 23:20
OSBotify pushed a commit that referenced this pull request Jun 30, 2022
@NikkiWines @OSBotify
Merge pull request #9619 from Expensify/Rory-SetupGitForOSBotify
202b470 
Create composite action to set up git for OSBotify

(cherry picked from commit cc37166)
@OSBotify OSBotify mentioned this pull request Jun 30, 2022
Merged
OSBotify added a commit that referenced this pull request Jun 30, 2022
@OSBotify
Merge pull request #9656 from Expensify/OSBotify-cherry-pick-staging-…
e688e2b 
…9619

🍒 Cherry pick PR #9619 to staging 🍒
@OSBotify OSBotify mentioned this pull request Jun 30, 2022
Closed
71 tasks
@roryabraham roryabraham changed the title Create composite action to set up git for OSBotify [No QA] Create composite action to set up git for OSBotify Jun 30, 2022
@roryabraham
Copy link
Contributor Author

Weird, it still used triggerWorkflowAndWait in the last run caused by the CP: https://github.com/Expensify/App/runs/7141262294?check_suite_focus=true

@roryabraham
Copy link
Contributor Author

Going to manually CP something else to test it out.

@roryabraham
Copy link
Contributor Author

Manual CP running here

@roryabraham
Copy link
Contributor Author

Okay, this worked https://github.com/Expensify/App/runs/7141372706?check_suite_focus=true 🎉

@OSBotify OSBotify mentioned this pull request Jul 8, 2022
Closed
@OSBotify
Copy link
Contributor

OSBotify commented Jul 8, 2022

🚀 Deployed to production by @roryabraham in version: 1.1.79-17 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikkiWines NikkiWines NikkiWines approved these changes

Assignees

@roryabraham roryabraham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roryabraham @OSBotify @NikkiWines