Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] Use uuid to generate branch name in updateProtectedBranch #9639

Merged
merged 2 commits into from
Jun 30, 2022
Merged

[No QA] Use uuid to generate branch name in updateProtectedBranch #9639

merged 2 commits into from
Jun 30, 2022

Conversation

roryabraham
Copy link
Contributor

Details

Discussed in slack here.

Fixed Issues

$ #9638

Tests

CP this PR and verify that it works as expected.

@roryabraham roryabraham self-assigned this Jun 30, 2022
@roryabraham roryabraham requested a review from a team as a code owner June 30, 2022 16:18
@melvin-bot melvin-bot bot requested review from amyevans and removed request for a team June 30, 2022 16:18
@roryabraham roryabraham changed the title [No QA] Use uuid to generate branch name in updateProtectedBranch [HOLD] [No QA] Use uuid to generate branch name in updateProtectedBranch Jun 30, 2022
@roryabraham
Copy link
Contributor Author

Put on HOLD because some testing shows that environment variables are not available until later steps: https://github.com/Andrew-Test-Org/Public-Test-Repo/runs/7135686588?check_suite_focus=true

@roryabraham roryabraham changed the title [HOLD] [No QA] Use uuid to generate branch name in updateProtectedBranch [No QA] Use uuid to generate branch name in updateProtectedBranch Jun 30, 2022
@roryabraham
Copy link
Contributor Author

roryabraham commented Jun 30, 2022 •
edited
Loading

Okay, more testing showed that local bash variables become immediately available in the same step. So we'll use that instead

luacmartins
luacmartins approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@luacmartins luacmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Hopefully this will stop cascading failures. Also thanks for DRYing the code :)

@sketchydroide sketchydroide merged commit 3d6b958 into main Jun 30, 2022
@sketchydroide sketchydroide deleted the Rory-UniqueBranchName branch June 30, 2022 17:20
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@roryabraham
Copy link
Contributor Author

Going to manually CP this to test it out.

OSBotify pushed a commit that referenced this pull request Jun 30, 2022
@sketchydroide @OSBotify
Merge pull request #9639 from Expensify/Rory-UniqueBranchName
f5447c8 
(cherry picked from commit 3d6b958)
@OSBotify OSBotify mentioned this pull request Jun 30, 2022
Merged
@roryabraham
Copy link
Contributor Author

This seems to have worked fine 🎉 #9644

However, the CP failed, probably again due to #9640

@OSBotify OSBotify mentioned this pull request Jun 30, 2022
Closed
71 tasks
@OSBotify OSBotify mentioned this pull request Jul 8, 2022
Closed
@OSBotify
Copy link
Contributor

OSBotify commented Jul 8, 2022

🚀 Deployed to production by @roryabraham in version: 1.1.79-17 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sketchydroide sketchydroide sketchydroide approved these changes

@amyevans amyevans amyevans approved these changes

@luacmartins luacmartins luacmartins approved these changes

Assignees

@roryabraham roryabraham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@roryabraham @OSBotify @sketchydroide @amyevans @luacmartins