[No QA] Wait for checks to complete before giving up due to mergeable_state blocked #9643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roryabraham
changed the title
|
|
sketchydroide
approved these changes
Jun 30, 2022
|
Let's see if this works 🤞 |
OSBotify
pushed a commit
that referenced
this pull request
Jun 30, 2022
…Checks (cherry picked from commit 6bc73a6)
OSBotify
added a commit
that referenced
this pull request
Jun 30, 2022
…9643 🍒 Cherry pick PR #9643 to staging 🍒
71 tasks
|
This worked 🎉 At least ... it didn't break anything. Because we didn't have consistent reproduction steps for the race condition we'll have to wait and see and hopefully the failures we were seeing (pretty frequently) will stop happening |
|
🚀 Cherry-picked to staging by @roryabraham in version: 1.1.79-7 🚀
|
|
🚀 Deployed to production by @roryabraham in version: 1.1.79-17 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @sketchydroide
Details
Don't give up on mergeability of a PR until checks are complete.
Fixed Issues
$ #9640
Tests
Merge this PR with the CP Staging label and verify that the deploy happens as normal.