Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Pass secret as input to compound action #9651

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

roryabraham
Copy link
Contributor

Details

Following-up on #9618 to fix an oversight – secrets must be passed in as inputs to GitHub Actions:

To make a secret available to an action, you must set the secret as an input or environment variable in the workflow file ... GitHub automatically redacts secrets printed to the log

Fixed Issues

$ (partial) https://github.com/Expensify/Expensify/issues/195693

Tests

  1. Verify that PR checks pass on this PR.
  2. Merge this PR.
  3. Verify that other GH actions keep working. We'll notice if they don't 🙃
  4. Purposely run a workflow with an action that we know will fail. For example, attempt to manually CP a PR w/ a number that belongs to an issue instead of a pull request. That will definitely fail and should ping in #announce.

@roryabraham roryabraham requested a review from a team as a code owner June 30, 2022 20:53
@roryabraham roryabraham self-assigned this Jun 30, 2022
@melvin-bot melvin-bot bot requested review from Justicea83 and removed request for a team June 30, 2022 20:54
@roryabraham
Copy link
Contributor Author

@roryabraham
Copy link
Contributor Author

Merging to test

@roryabraham roryabraham merged commit 52ca757 into main Jun 30, 2022
@roryabraham roryabraham deleted the Rory-FixSecretsInCompoundAction branch June 30, 2022 21:00
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@roryabraham
Copy link
Contributor Author

This worked 🎉

@OSBotify
Copy link
Contributor

OSBotify commented Jul 8, 2022

🚀 Deployed to staging by @roryabraham in version: 1.1.81-0 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 failure ❌

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.82-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants