Fix off-by-one error in scrollToIndex #9674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
NikkiWines
approved these changes
Jul 1, 2022
OSBotify
pushed a commit
that referenced
this pull request
Jul 1, 2022
Fix off-by-one error in scrollToIndex (cherry picked from commit 6299646)
OSBotify
added a commit
that referenced
this pull request
Jul 1, 2022
…9674 🍒 Cherry pick PR #9674 to staging 🍒
71 tasks
| @@ -226,7 +226,7 @@ class OptionsSelector extends Component { | |||
| focusedIndex: newFocusedIndex, | |||
| }); | |||
|
|
|||
| if (newOptions.length <= newFocusedIndex) { | |||
| if (newOptions.length < newFocusedIndex) { | |||
There was a problem hiding this comment.
@roryabraham when the search query has no results, this check will fail (0 < 0).
And we'll scroll to index 0 which doesn't exist, causing the app to crash.
Steps
- ⌘ + K
- Search for an user which doesn't exist.
Result:
There was a problem hiding this comment.
This change is also causing #9685
There was a problem hiding this comment.
Thanks for pointing this out. Revert PR here: #9690
|
🚀 Deployed to production by @roryabraham in version: 1.1.79-17 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
I'm not able to reproduce the error, but looking at the logs in the video it makes sense that this would fix it. If the length of options is equal to the index, then we'll get an index-out-of-bounds error:
Fixed Issues
$ #9671
Tests
Unknown since the original issue is not consistently reproducible.
QA Steps
Attempt to reproduce #9671 🤷