Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Make temporary copies of moved javascript actions #9784

Merged
merged 2 commits into from
Jul 8, 2022

Conversation

roryabraham
Copy link
Contributor

Details

This is a temporary fix that will be reverted after the prod deploy goes out. Slack context: https://expensify.slack.com/archives/C03V9A4TB/p1657234652096509 h\t @francoisl for the idea

I determined which actions to copy by looking on the production at the remaining workflows that need to complete the production deploy and searching each file for uses: Expensify/App/:

Fixed Issues

$ n/a – broken prod deploy https://github.com/Expensify/App/runs/7242854102?check_suite_focus=true

Tests

  1. Merge this PR
  2. Retry https://github.com/Expensify/App/runs/7242854102?check_suite_focus=true
  3. Hope that the production deploy works
  4. Revert this PR.

@roryabraham roryabraham requested a review from a team as a code owner July 8, 2022 01:48
@roryabraham roryabraham self-assigned this Jul 8, 2022
@melvin-bot melvin-bot bot requested review from sketchydroide and removed request for a team July 8, 2022 01:49
@OSBotify
Copy link
Contributor

OSBotify commented Jul 8, 2022

🚀 Deployed to staging by @roryabraham in version: 1.1.82-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.82-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants