Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create production release #1859

Merged
merged 3 commits into from
Mar 18, 2021
Merged

Create production release #1859

merged 3 commits into from
Mar 18, 2021

Conversation

roryabraham
Copy link
Contributor

@roryabraham roryabraham commented Mar 18, 2021

Details

Creates a Github Release to trigger a production deploy. The release body just has the list of PRs which it includes for now. This code should make it pretty easy to add more changelog notes and/or other files or artifacts with the release.

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/155221

Tests

Still haven't tested action-gh-release in Public-Test-Repo.

To live-test this PR:

  1. Merge this PR
  2. Close a StagingDeployCash, and assuming Create finishReleaseCycle workflow #1858 is working as expected, then the production job of the deploy workflow should be triggered.
  3. It should then create a Github Release matching the tag from the StagingDeployCash that was closed.
  4. That should trigger all the platform-specific deploy workflows (although the actual production deploy may be skipped for the time being, until we flip the switch).

@roryabraham roryabraham requested a review from a team as a code owner March 18, 2021 07:55
@roryabraham roryabraham self-assigned this Mar 18, 2021
@botify botify requested review from Gonals and removed request for a team and Gonals March 18, 2021 07:55
@roryabraham roryabraham changed the title [HOLD PR #1858] [WIP] Create production release Create production release Mar 18, 2021
token: ${{ secrets.OS_BOTIFY_TOKEN }}

- name: Checkout production branch
run: git checkout production
Copy link
Contributor

@AndrewGable AndrewGable Mar 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NAB: Can you combine here with actions/checkout?

@AndrewGable AndrewGable merged commit 8168b7d into master Mar 18, 2021
@AndrewGable AndrewGable deleted the Rory-CreateProductionRelease branch March 18, 2021 23:41
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2021
@roryabraham
Copy link
Contributor Author

@roryabraham
Copy link
Contributor Author

Retesting after merging #1901 ...

Failed at a later step this time! Getting closer... We'll pick this back up tomorrow.

@roryabraham
Copy link
Contributor Author

roryabraham commented Mar 19, 2021

I think the last error we saw last night was caused because there were no existing releases. We could add code to handle that edge case, but instead I think we can just create a release using the UI.

Created here

@roryabraham
Copy link
Contributor Author

Retesting after manually creating a couple releases:

Failed at a later step again!

@roryabraham
Copy link
Contributor Author

image

That doesn't match the docs!

image

😠 ... probably has to do with the commit hash we're pointing at

@roryabraham
Copy link
Contributor Author

roryabraham commented Mar 19, 2021

Yeah, we're pointing at b7e450d, and:

image

I'm just going to point at the latest commit. PR here

@roryabraham
Copy link
Contributor Author

roryabraham commented Mar 19, 2021

Retesting after merging #1921 ...

image

https://github.com/Expensify/Expensify.cash/actions/runs/668825231 note that this workflow was triggered on: release

🎉 IT WORKED 🎉

@AndrewGable
Copy link
Contributor

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants