Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update commit hash of softprops/action-gh-release action #1921

Merged
merged 1 commit into from
Mar 19, 2021

Conversation

roryabraham
Copy link
Contributor

Details

Following up on testing this PR

We were using options of the softprops/action-gh-release action which were not available in the commit hash we were pointing to. So this PR just updates our workflow to point to the latest commit hash in the action-gh-release repo.

@roryabraham roryabraham requested a review from AndrewGable March 19, 2021 17:44
@roryabraham roryabraham self-assigned this Mar 19, 2021
@roryabraham roryabraham requested a review from a team as a code owner March 19, 2021 17:44
@botify botify requested review from Luke9389 and removed request for a team March 19, 2021 17:44
@AndrewGable AndrewGable removed the request for review from Luke9389 March 19, 2021 17:49
@AndrewGable
Copy link
Contributor

Looks great- Merging before e2e to get production deploys working!

@AndrewGable AndrewGable merged commit ec2ffc2 into master Mar 19, 2021
@AndrewGable AndrewGable deleted the Rory-UpdateActionGHReleaseHash branch March 19, 2021 17:49
@botify
Copy link

botify commented Mar 19, 2021

@AndrewGable looks like this was merged without passing tests. Please add a note explaining why this was done or remove the Emergency label if this is not an emergency.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants