Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefer-underscore-method exception for React.Children.map #44

Merged
merged 2 commits into from
Jan 28, 2022

Conversation

roryabraham
Copy link
Contributor

Fixes Expensify/App#7447

Automated tests added.

luacmartins
luacmartins previously approved these changes Jan 27, 2022
Copy link
Contributor

@luacmartins luacmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM! Thanks @roryabraham!

marcaaron
marcaaron previously approved these changes Jan 28, 2022
@marcaaron
Copy link
Contributor

bump the version?

@marcaaron marcaaron dismissed their stale review January 28, 2022 00:34

bump it up

@luacmartins
Copy link
Contributor

Nice catch @marcaaron!

@roryabraham
Copy link
Contributor Author

Lol I always forget 😓

At some point I want to set up GitHub Actions here to just bump the version and publish straight to npm.

@roryabraham
Copy link
Contributor Author

Version bumped!

@luacmartins
Copy link
Contributor

Merging since Marc's only comment was addressed.

@luacmartins luacmartins merged commit b8f659f into main Jan 28, 2022
@luacmartins luacmartins deleted the Rory-ReactChildrenMap branch January 28, 2022 00:43
@roryabraham
Copy link
Contributor Author

Pinged in slack to get this deployed.

@roryabraham
Copy link
Contributor Author

Published in 2.0.23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken ESLint Rule - prefer-underscore-map
3 participants