Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: parsing mention wrapped with styles inside link text #549

Merged
merged 2 commits into from
Jun 14, 2023
Merged

fix: parsing mention wrapped with styles inside link text #549

merged 2 commits into from
Jun 14, 2023

Conversation

eh2077
Copy link
Contributor

@eh2077 eh2077 commented Jun 14, 2023

Fixed Issues

$ Expensify/App#19997

Tests

  1. Go to a chat and add a comment
[_@[email protected]_](expensify.com)
  1. Verify that the text @[email protected] of link is not rendered as mention and is italic

QA

Same as test

@eh2077 eh2077 requested a review from a team as a code owner June 14, 2023 11:33
@melvin-bot melvin-bot bot requested review from luacmartins and removed request for a team June 14, 2023 11:33
@eh2077 eh2077 mentioned this pull request Jun 14, 2023
Closed
6 tasks
s77rt
s77rt suggested changes Jun 14, 2023
View reviewed changes
@eh2077 eh2077 requested a review from s77rt June 14, 2023 13:08
s77rt
s77rt approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@s77rt s77rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

cc @luacmartins

luacmartins
luacmartins approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@luacmartins luacmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luacmartins luacmartins merged commit f9985d5 into Expensify:main Jun 14, 2023
@johnmlee101
Copy link
Contributor

Wasn't I suppose to be assigned?

@luacmartins
Copy link
Contributor

I think so, not sure why Melvin assigned me instead 🤔

@s77rt
Copy link
Contributor

s77rt commented Jun 15, 2023

I think auto assignment never worked correctly cross repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s77rt s77rt s77rt approved these changes

@luacmartins luacmartins luacmartins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eh2077 @johnmlee101 @luacmartins @s77rt