Bump expensify-common version #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
reviewed
Feb 11, 2024
| @@ -20,7 +20,7 @@ | |||
| "typescript": "^5.3.3" | |||
| }, | |||
| "dependencies": { | |||
| "expensify-common": "git+ssh://[email protected]/Expensify/expensify-common.git#039f4c584655cb4b5e933c9058b84ead7c8c6aee", | |||
There was a problem hiding this comment.
It looks like Expensify/App uses a different commit: https://github.com/Expensify/App/blob/06c7dac74ad5bcc8009c614570625afe4006f621/package.json#L103
There was a problem hiding this comment.
Yes, I'm now creating the PR with bumping version in Expensify/App as well so it will be aligned
There was a problem hiding this comment.
I'll wait to E/App PR to be merged, before this one
There was a problem hiding this comment.
Okay, but can you merge main now to resolve conflict?
tomekzaw
previously approved these changes
Feb 11, 2024
50 tasks
|
Fixes #179 |
tomekzaw
previously approved these changes
Feb 11, 2024
tomekzaw
approved these changes
Feb 15, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
closes #138
Related Issues
#138
Manual Tests
Verify that app is building correctly and text is being parsed
Linked PRs
N/A