Merge pull request #194 from Expensify/marcaaron-fixLoops

Revert for loop reverse iteration

lib/Onyx.js

@@ -262,7 +262,7 @@ function keysChanged(collectionKey, partialCollection) {
     // individual collection key member for the collection that is being updated. It is important to note that the collection parameter cane be a PARTIAL collection
     // and does not represent all of the combined keys and values for a collection key. It is just the "new" data that was merged in via mergeCollection().
     const stateMappingKeys = _.keys(callbackToStateMapping);
-    for (let i = stateMappingKeys.length; i--;) {
+    for (let i = 0; i < stateMappingKeys.length; i++) {
         const subscriber = callbackToStateMapping[stateMappingKeys[i]];
         if (!subscriber) {
             continue;
@@ -383,7 +383,7 @@ function keyChanged(key, data) {
     // notify them if the key that changed is a collection member. Or if it is a regular key notify them when there is an exact match. Depending on whether the subscriber
     // was connected via withOnyx we will call setState() directly on the withOnyx instance. If it is a regular connection we will pass the data to the provided callback.
     const stateMappingKeys = _.keys(callbackToStateMapping);
-    for (let i = stateMappingKeys.length; i--;) {
+    for (let i = 0; i < stateMappingKeys.length; i++) {
         const subscriber = callbackToStateMapping[stateMappingKeys[i]];
         if (!subscriber || !isKeyMatch(subscriber.key, key)) {
             continue;