Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more logs to help identify cause of race condition #110

Closed
marcaaron opened this issue Nov 3, 2021 · 2 comments
Closed

Add more logs to help identify cause of race condition #110

marcaaron opened this issue Nov 3, 2021 · 2 comments
Assignees

Comments

@marcaaron
Copy link
Contributor

marcaaron commented Nov 3, 2021

We added some logs in this PR to help see if set() is ever called while the mergeQueue is processing - which would prove a race condition and there have been very few times that it has occurred.

However, the ones that have occurred are really perplexing and all seem related to storage eviction. So we should add more logs to see if we can get anymore information about the error. All happened on web + using Chrome.

2021-11-03_08-19-20

2021-11-03_09-09-35

@marcaaron
Copy link
Contributor Author

Catching up on this hunch here and we had 9 logs of this in the past week all were when the cache eviction was triggered for a reportActions_* key and that somehow caused a set() to happen while we had a pending merge set up for a report_*.

Gonna try to re-create a storage eviction event and see why the error causes set() to be called after a merge() and if we can do anything about it.

@marcaaron
Copy link
Contributor Author

With the addition of IndexedDB, we can probably just ignore this issue for now unless it becomes a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant