Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump react-native-onyx to next version #6195

Merged
merged 2 commits into from
Nov 23, 2021
Merged

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Nov 3, 2021

Details

See linked issue

Fixed Issues

$ Expensify/react-native-onyx#110

Tests

  1. Build the web app and verify that the logs are shown when Onyx tries to set some data.
  2. Add several large reports (clitools generator:chatreport) and trigger storage eviction (it will go faster if you alter the limit here) and you should see logs like this
[info] [Onyx] set() called for key: reportActions_1127 properties: 0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,39,40,41,42,43,44,45,46,47,48,49,50,51,52,53,54,55,56,57,58,59,60,61,62,63,64,65,66,67,68,69,70,71,72,73,74,75,76,77,78,79,80,81,82,83,84,85,86,87,88,89,90,91,92,93,94,95,96,97,98,99,100,101,102,103,104,105,106,107,108,109,110,111,112,113,114,115,116,117,118,119,120,121,122,123,124,125,126,127,128,129,130,131,132,133,134,135,136,137,138,139,140,141,142,143,144,145,146,147,148,149,150,151,152,153,154,155,156,157,158,159,160,161,162,163,164,165,166,167,168,169,170,171,172,173,174,175,176,177,178,179,180,181,182,183,184,185,186,187,188,189,190,191,192,193,194,195,196,197,198,199,200,201,202,203,204,205,206,207,208,209,210,211,212,213,214,215,216,217,218,219,220,221,222,223,224,225,226,227,228,229,230,231,232,233,234,235,236,237,238,239,240,241,242,243,244,245,246,247,248,249,250,251,252,253,254,255,256,257,258,259,260,261,262,263,264,265,266,267,268,269,270,271,272,273,274,275,276,277,278,279,280,281,282,283,284,285,286,287,288,289,290,291,292,293,294,295,296,297,298,299,300,301,302,303,304,305,306,307,308,309,310,311,312,313,314,315,316,317,318,319,320,321,322,323,324,325,326,327,328,329,330,331,332,333,334,335,336,337,338,339,340,341,342,343,344,345,346,347,348,349,350,351,352,353,354,355,356,357,358,359,360,361,362,363,364,365,366,367,368,369,370,371,372,373,374,375,376,377,378,379,380,381,382,383,384,385,386,387,388,389,390,391,392,393,394,395,396,397,398,399,400,401,402,403,404,405,406,407,408,409,410,411,412,413,414,415,416,417,418,419,420,421,422,423,424,425,426,427,428,429,430,431,432,433,434,435,436,437,438,439,440,441,442,443,444,445,446,447,448,449,450,451,452,453,454,455,456,457,458,459,460,461,462,463,464,465,466,467,468,469,470,471,472,473,474,475,476,477,478,479,480,481,482,483,484,485,486,487,488,489,490,491,492,493,494,495,496,497,498,499,500 - ""
Log.js:41 [info] [Onyx] Handled error: QuotaExceededError: Failed to execute 'setItem' on 'Storage': Setting the value of 'reportActions_1127' exceeded the quota. - ""
Log.js:41 [info] [Onyx] Out of storage. Evicting least recently accessed key (reportActions_1112) and retrying. - ""

QA Steps

We are just adding some additional logs here so there's not much to test besides obvious regressions.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

@marcaaron marcaaron self-assigned this Nov 3, 2021
@marcaaron marcaaron requested a review from Julesssss November 3, 2021 20:45
@Julesssss
Copy link
Contributor

Julesssss commented Nov 8, 2021

Please bump me on this once the PR is merged (if I forget)

@marcaaron
Copy link
Contributor Author

Cool. I left a comment there.

@Julesssss
Copy link
Contributor

This can come off hold now 👍

@marcaaron marcaaron changed the title [HOLD react-native-onyx 110] Bump onyx to next version [HOLD] Bump onyx to next version Nov 9, 2021
@marcaaron marcaaron changed the title [HOLD] Bump onyx to next version Bump react-native-onyx to next version Nov 9, 2021
@marcaaron marcaaron marked this pull request as ready for review November 9, 2021 15:19
@marcaaron marcaaron requested a review from a team as a code owner November 9, 2021 15:19
@MelvinBot MelvinBot requested review from cead22 and removed request for a team November 9, 2021 15:19
@marcaaron
Copy link
Contributor Author

Gonna but a hold on this for 11/19. This PR will just add some logging for a weird edge case I am tracking, but it is not urgent and I will be OOO for the next week anyway.

@marcaaron marcaaron changed the title Bump react-native-onyx to next version [HOLD 11/19] Bump react-native-onyx to next version Nov 12, 2021
@marcaaron marcaaron changed the title [HOLD 11/19] Bump react-native-onyx to next version Bump react-native-onyx to next version Nov 22, 2021
@marcaaron
Copy link
Contributor Author

Taking off hold now that I am back from OOO and can keep an eye on this one :)

@Julesssss Julesssss merged commit 468be4a into main Nov 23, 2021
@Julesssss Julesssss deleted the marcaaron-bumpOnyxVersion branch November 23, 2021 20:30
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Julesssss in version: 1.1.16-11 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Dec 6, 2021

🚀 Deployed to production by @roryabraham in version: 1.1.17-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants