Let the OS choose the server port when the config doesn't have one. #504
Conversation
| @@ -578,7 +578,7 @@ serverConnection: EQTOKEN_CONNECTION | |||
| '{' { | |||
| connectionDescription = new eq::server::ConnectionDescription; | |||
| connectionDescription->setHostname( "" ); | |||
| connectionDescription->port = EQ_DEFAULT_PORT; | |||
| connectionDescription->port = 0; // OS chosen port | |||
There was a problem hiding this comment.
Ui, so innocently looking, but still a dragon. This at least should break the admin API for window creation. Investigating.
|
convert11Visitor.h:49 |
|
Shouldn't convert11Visitor.h:49 be also 0 and remove EQ_DEFAULT_PORT completely? |
|
Yes, was more a note-to-self. |
|
With this commit RTNeuron can create auxiliary windows for the offscreen snapshot. |
|
+1 if convert11Visitor.h:49 is using '0' |
hernando
force-pushed
the
no_default_port
branch
from
ef468d9 to
e33fbd0
Compare
|
I've removed the spurious warning from Client::connectServer. |
hernando
force-pushed
the
no_default_port
branch
from
e33fbd0 to
ee6a861
Compare
| if( server->getConnectionDescriptions().empty( )) | ||
| { | ||
| connDesc = new co::ConnectionDescription; | ||
| connDesc->port = EQ_DEFAULT_PORT; |
There was a problem hiding this comment.
No, this should stay. This is for the standalone server, which still runs on the hardcoded port.
There was a problem hiding this comment.
I removed it without remembering there was a tool to start a server process.
I've never used the resident server process and I don't think I'll ever use it. For debugging purposes I've always found misleading to have a connection error trying to access the default server (where default means a different port in each machine because the uid may change, so it's not really hardcoded). Since having a resident server is not the primary use case, don't you think it's better to require the server URI explicitly in this case with EQ_SERVER (explicit better than implicit).
This was already the case when no configuration file was provided, the behavior is now extended to the configuration files where the port is not given. This is needed to be able to run tests that use config files in parallel reliably.
hernando
force-pushed
the
no_default_port
branch
from
ee6a861 to
41db4c1
Compare
|
Failing because the GPFS is down in Lugano. |
|
+1 |
|
retest this please |
Let the OS choose the server port when the config doesn't have one.
Among other things, this is needed to be able to run tests that use
config files in parallel reliably.