Add timeout for tests #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each request has a timeout of 30000ms and 3 retries. So a test timeout of 100000 should prevent the test from timing out before the request is complete.
For some reason the server responds much faster with this request header
fdesjardins
approved these changes
Oct 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each request has a timeout of 30000ms and 3 retries. So a test timeout of 100000 should prevent the test from timing out before the request is complete.
Also updated
superagentto latest version to fix retry after a timeout.Also added
Accept: text/htmlheader to FAA requests, which fixes most of the response issues with the FAA website.