Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyproject.toml to avoid pre-installs with pip #142

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

AxelHenningsson
Copy link
Contributor

An attempt to make ImageD11 installable with pip in a clean environment, without any prerequisites.

On a windows 10 using conda (as below) this installs with pip and passes pytest without any pre-installed packages such as numpy or the like. To replicate:

 conda create -n dev_ImageD11 python=3.8
 conda activate dev_ImageD11 
 git clone https://github.com/FABLE-3DXRD/ImageD11.git
 cd ImageD11
 pip install -e .
 conda install pytest
 pytest

@AxelHenningsson AxelHenningsson linked an issue Feb 19, 2022 that may be closed by this pull request
@AxelHenningsson AxelHenningsson self-assigned this Feb 20, 2022
@jonwright
Copy link
Member

I will merge as is but I have in mind that pytest should be coming in somehow automatically too?

@jonwright jonwright merged commit 84073e8 into FABLE-3DXRD:master Feb 21, 2022
@AxelHenningsson
Copy link
Contributor Author

Yeah I was surprised that the CI does not trigger tests on a pull requests. I have mostly used GitHub actions to do CI stuff, so don't exactly know how the .circleci file works with tests in ImageD11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pyproject.toml with requires=["numpy"]
2 participants