Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new solver for strain and stress #192

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

jbjacob94
Copy link
Contributor

Create a new solver to compute strain and stress from ImageD11 ubis

Create a new solver to compute strain and stress from ImageD11 ubis
@jonwright
Copy link
Member

Thanks!!

I think we can merge this as it is and fix the python2.7 CI later (I guess it is just reformatting the f-strings).

Pinging @jadball and @AxelHenningsson as they have similar codes and might have good ideas for creating some testcases to verify the numbers and keep things working into the future

@jonwright jonwright merged commit 2524a63 into FABLE-3DXRD:master Dec 7, 2023
2 of 4 checks passed
@AxelHenningsson
Copy link
Contributor

Hi! It would be great with some Context? Is there any new maths here?

Cheers
Axel

@jonwright
Copy link
Member

The conversion from strain to stress ought to match the old code in FitAllB. I think the invariants and eigen decompositions are new as python code here, but the maths should be known. A missing link (for me) is to have a verifiable check whether the numbers come out right for some low symmetry cases (e.g. quartz for trigonal vs hexagonal). There are some factors of 2 and sqrt(2) that are not obvious.

@AxelHenningsson
Copy link
Contributor

AxelHenningsson commented Dec 7, 2023

I try to stick to the IEEE conventions for stiffness matrices. Is that what is used here? I think a link in the constructor to the convention used would be good.

As for testing I suppose you have to do a pen and paper calculation and then verify that the code agrees.

Best,
Axel

@jbjacob94
Copy link
Contributor Author

jbjacob94 commented Dec 7, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants