-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated patterns in Cij_symmetry #196
Conversation
…ties function - corrected a few mistakes and typos in function description - corrected a mistake in convert_tensors_to_vect - changed invariant_prop function to return von Mises stress / strain instead of octahedral shear stress / strain
Should we find another name instead of "eps_sig_solver_NEW.py" ? I added the 'NEW' string to avoid overwriting the former code in eps_sig_solver.py, but this is not a very informative title. Maybe eps_sig_solver_py3, to mention it is free of any python 2 dependency? |
No - please keep the python 2 dependency! Otherwise. we cannot test it against FitAllB. |
It is just the file name, this should not affect dependencies, no? |
For the name I would go for something shorter, like "stress.py" for example. We can move the older code into the depreciated folder if the functionality is replaced. |
ok, go for it! |
If I do it now you will need to rebase / merge the change. Isn't it easier to fix the errors in Actions on this one, merge it, and then rename? You can just do:
... and at the same time fix the typos. |
Are you seeing the CI?
|
Yes, I can see the CI. I just did a mess by mixing up different version, and was trying to restore everything back to normal. I thought all this was only happening into my branch, not on the main one. Sorry if you have received tons of error messages... |
updated patterns in Cij_symmetry to form the stiffness matrix in different symmetries, according to this paper:
Mouhat, F., & Coudert, F.-X. (2014). Necessary and sufficient elastic stability conditions in various crystal systems. Physical Review B, 90(22), 224104