Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometry overhaul (+tests), update all notebooks #276

Merged
merged 21 commits into from
Apr 11, 2024

Conversation

jadball
Copy link
Contributor

@jadball jadball commented Apr 11, 2024

  • Refactor of ImageD11.sinograms.geometry
    • Now tested in test/test_geometry.py
    • Updated ImageD11.sinograms.point_by_point accordingly
      • This has been validated against lab geometry and sinograms method for the Al foil + wire sample
    • Demonstration notebook available in sandbox/scanning_geometry.ipynb
  • Added get_cf_3d_from_disk() method to ImageD11.sinograms.dataset
  • Updated shift mechanics in run_iradon() and run_mlem() inside ImageD11.sinograms.roi_iradon
    • Replaced y0 parameter with shift (because we don't shift by y0 anyway)
    • Removed errant negative sign in the shift call
    • Updated ImageD11.sinograms.sinogram to match this
  • Fixed some HDF5 IO bugs in ImageD11.sinograms.sinogram

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jonwright
Copy link
Member

I will merge, but there are some things to look at. In point_by_point it was intentional to precompute the cos/sin omega before doing the dtymask selection for each point...

@jonwright jonwright merged commit a1b1e1b into FABLE-3DXRD:master Apr 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants