Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TensorMap slow import #352 #375

Merged
merged 4 commits into from
Jan 14, 2025
Merged

TensorMap slow import #352 #375

merged 4 commits into from
Jan 14, 2025

Conversation

CiolJegou
Copy link

Adding (cache = True) in the numba occurences
On first import :

CPU times: user 9.63 s, sys: 390 ms, total: 10 s
Wall time: 12 s

On second import (after restarting the kernel) :

CPU times: user 716 ms, sys: 298 ms, total: 1.01 s
Wall time: 960 ms

@jonwright
Copy link
Member

Thanks Loïc! Can you just remove the auto-generated _cImageD11 files? These are not needed in git and they are different for each python/numpy version so I prefer not to commit them.

@jadball
Copy link
Contributor

jadball commented Jan 13, 2025

Thanks! Also please apply cache=True to Numba functions inside ImageD11/sinograms/point_by_point.py if possible :)

@jadball jadball merged commit 6ed46f3 into FABLE-3DXRD:master Jan 14, 2025
6 checks passed
@jadball jadball mentioned this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants