style to disability and services pages #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suuuuha
changed the title
Suuuuha
changed the title
m4v15
requested changes
Jun 6, 2017
public/js/public.js
Outdated
| // convert this to actual array from 'array-like' object | ||
| var filterButtonsArray = [].slice.call(filterButtons) | ||
| var buttons = filterButtons.querySelectorAll('button') | ||
| console.log(buttons) |
public/assets/icons/BACK_btn.svg
Outdated
| @@ -3,7 +3,7 @@ | |||
| <!-- Generator: Sketch 44 (41411) - http://www.bohemiancoding.com/sketch --> | |||
m4v15
requested changes
Jun 6, 2017
views/services.hbs
Outdated
| <section class=""> | ||
| <div class=""> | ||
| <a href="/" aria-label={{text.back}}><img src="./assets/icons/BACK_btn.svg" ></a> | ||
| <section class="white fixed top-0 mb3"> |
There was a problem hiding this comment.
can we have the "w-100 tc" classes like we do in the home.hbs to centre everything?
I've done it and it works fine, except it means the arrow is in the centre. This can be fixed by using float left or right or whatever, but then it's the same for arabic or english, so one of them is in the wrong place always 😢
I think probably its better to have the arrow in the centre and make the site as a whole look better than to have the arrow to the right. we can always fix the position using a helper or something.
views/services.hbs
Outdated
| <a href="/" aria-label={{text.back}}><img src="./assets/icons/BACK_btn.svg" ></a> | ||
| <section class="white fixed top-0 mb3"> | ||
| <div class="mt4 pt2 f3 mh2"> | ||
| <a href="/" class="near-white" aria-label={{text.back}}><i aria-hidden="true" class="{{{chooseBack dir}}}"></i></a> |
There was a problem hiding this comment.
maybe add "dim" class so it dims when you hover over it
m4v15
approved these changes
Jun 7, 2017
MohamedOmarii
approved these changes
Jun 7, 2017
hibaakel
approved these changes
Jun 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #101 #102 #142