Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

db_connection file needs to be modified #37

Open
MohamedOmarii opened this issue Apr 6, 2017 · 0 comments
Open

db_connection file needs to be modified #37

MohamedOmarii opened this issue Apr 6, 2017 · 0 comments
Assignees
@hibaakel
Labels
addressed

Comments

@MohamedOmarii
Copy link
Member

require('env2')('./config.env'); why this not in varibale or const ?
i think it a better to be in var or const
and the max in the const options should be process.env.MAX_CONNECTIONS || 2, not 2
@hibaakel hibaakel self-assigned this Apr 6, 2017
hibaakel pushed a commit that referenced this issue Apr 6, 2017
correct the max connections #37
d521b8d
@hibaakel hibaakel mentioned this issue Apr 6, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hibaakel hibaakel

Labels
addressed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MohamedOmarii @hibaakel