Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Clarify valid motion_estimate_filter settings #1432

Merged
merged 2 commits into from
Feb 9, 2021

Conversation

shnizzedy
Copy link
Member

@shnizzedy shnizzedy commented Feb 5, 2021

Fixes

Fixes #1425 by @shnizzedy

Description

run filter_type breathing_rate_min breathing_rate_max center_frequency filter_bandwidth lowpass_cutoff
off doesn't matter doesn't matter doesn't matter doesn't matter doesn't matter doesn't matter
on notch required required doesn't matter doesn't matter doesn't matter
on notch None None required required doesn't matter
on lowpass required doesn't matter doesn't matter doesn't matter doesn't matter
on lowpass None doesn't matter doesn't matter doesn't matter required

Prior to this change, the schema validation would raise an error on load if both motion estimate filter design options were provided (the alternative listed in #1430:

We can also throw an error, but this may be too disruptive.

)

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop_v1.8_convergence branch of the repository.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I updated the changelog.
  • I added or updated documentation (FCP-INDI/fcp-indi.github.io@fce06bf).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@shnizzedy shnizzedy requested a review from sgiavasis February 5, 2021 16:05
@shnizzedy shnizzedy force-pushed the config/motion-estimate-filter branch from 4661bad to c83bf0f Compare February 5, 2021 16:11
@shnizzedy shnizzedy force-pushed the config/motion-estimate-filter branch from c83bf0f to a66ded6 Compare February 5, 2021 16:13
@sgiavasis sgiavasis merged commit b96f12c into develop_v1.8_convergence Feb 9, 2021
@shnizzedy shnizzedy deleted the config/motion-estimate-filter branch February 9, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants