Workbench bugfix cavity #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
patrickscholz
commented
Jun 30, 2021
patrickscholz
commented
- also set runoff below cavity to zero
- improve freshwater balancing below cavity
- add some comments
…ly added in ice_therm when there is no cavity otherwise balancing might be corrupted
…t since under the cavity there is rigid lid approximation
|
@dsidoren and @koldunovn could one of you please merge that pull request! |
wiltonloch
pushed a commit
to wiltonloch/fesom2
that referenced
this pull request
Feb 1, 2023
Workbench bugfix cavity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.