FHU: Fix shebang line parsing #4224
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is used to parse shebang lines, and Linux does not parse shebang lines like shell command lines. Instead, it only splits it into an interpreter and an optional single argument, with leading/trailing whitespace stripped.
Sonicadvance1
approved these changes
Dec 20, 2024
neobrain
reviewed
Dec 23, 2024
| @@ -8,32 +8,39 @@ | |||
| namespace FHU { | |||
|
|
|||
| /** | |||
| * @brief Parses a string of arguments, returning a vector of string_views. | |||
| * @brief Parses a shebang string, returning a vector of string_views. | |||
There was a problem hiding this comment.
Sadly this heavy change in semantics makes ParseArgumentsFromString a misnomer. It's no longer a generic argument parser, so the function/header file/unit test should be renamed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is used to parse shebang lines, and Linux does not parse shebang lines like shell command lines. Instead, it only splits it into an interpreter and an optional single argument, with leading/trailing whitespace stripped.