Add variant for MixedElement #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbrubeck
force-pushed
the
pbrubeck/feature/mixed-variant
branch
from
51af898 to
2a907e2
Compare
|
We have plans to remove the passing of variants around like this as part of the UFL restructure, but I'd be happy to merge this and have it included in the release(s) before we start changing the interface. @pbrubeck Could you merge main into your branch so that's not blocking the merge |
|
merging this into my branch so I can combine it with #17 and get them merged |
garth-wells
pushed a commit
that referenced
this pull request
Jan 6, 2023
* add variant for MixedElement (#129) * Allow VectorElement to take a variant argument. (#17) Co-authored-by: Patrick Farrell <[email protected]> Co-authored-by: Pablo Brubeck <[email protected]> Co-authored-by: Patrick E. Farrell <[email protected]> Co-authored-by: Patrick Farrell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.