code analyzer fixes

FFXIV-CombatReborn · Dec 30, 2024 · 68ca103 · 68ca103
1 parent 6bc497b
commit 68ca103
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/BossMod/Modules/Dawntrail/Hunt/RankA/Keheniheyamewi.cs b/BossMod/Modules/Dawntrail/Hunt/RankA/Keheniheyamewi.cs
@@ -86,12 +86,12 @@ public override void OnCastStarted(Actor caster, ActorCastInfo spell)
 
     public override void OnCastFinished(Actor caster, ActorCastInfo spell)
     {
-        if (spell.Action.ID == (uint)AID.SlipperyScatterscourge)
+        if (_caster != null && spell.Action.ID == (uint)AID.SlipperyScatterscourge)
         {
             var finalPos = GetRectEndPosition(_caster.Position, _caster.Rotation, _shapeRect.LengthFront);
             var futureActivation = WorldState.FutureTime(10);
 
-            for (int i = 0; i < _activeAOEs.Count; i++)
+            for (int i = 0; i < _activeAOEs.Count; ++i)
             {
                 var aoe = _activeAOEs[i];
                 if (aoe.Shape == _shapeDonut)
@@ -165,4 +165,4 @@ public KeheniheyamewiStates(BossModule module) : base(module)
 }
 
 [ModuleInfo(BossModuleInfo.Maturity.Verified, Contributors = "Shinryin", GroupType = BossModuleInfo.GroupType.Hunt, GroupID = (uint)BossModuleInfo.HuntRank.A, NameID = 13401)]
-public class Keheniheyamewi(WorldState ws, Actor primary) : SimpleBossModule(ws, primary);
+public class Keheniheyamewi(WorldState ws, Actor primary) : SimpleBossModule(ws, primary);
diff --git a/BossMod/Modules/Dawntrail/Hunt/RankA/Pkuucha.cs b/BossMod/Modules/Dawntrail/Hunt/RankA/Pkuucha.cs
@@ -22,7 +22,7 @@ class PeckingFlurry(BossModule module) : Components.RaidwideCast(module, ActionI
 
 class MarchingSamba(BossModule module) : Components.GenericAOEs(module)
 {
-    private List<AOEInstance> _aoes = new();
+    private readonly List<AOEInstance> _aoes = [];
     private Actor? _caster;
     private static readonly AOEShapeCircle _circle = new(12);
     private static readonly AOEShapeCone _cone = new(40, 90.Degrees());
@@ -49,8 +49,8 @@ public override void OnCastStarted(Actor caster, ActorCastInfo spell)
         if ((AID)spell.Action.ID is AID.MarchingSamba or AID.MesmerizingMarch)
         {
             _caster = caster;
-            _aoes.Add(new(_circle, caster.Position, caster.Rotation, WorldState.CurrentTime.AddSeconds(6.5f), Colors.Danger, true));
-            _aoes.Add(new(_cone, caster.Position, caster.Rotation, WorldState.CurrentTime.AddSeconds(8), Colors.AOE, true));
+            _aoes.Add(new(_circle, caster.Position, caster.Rotation, WorldState.CurrentTime.AddSeconds(6.5f), Colors.Danger));
+            _aoes.Add(new(_cone, caster.Position, caster.Rotation, WorldState.CurrentTime.AddSeconds(8)));
         }
     }
 
@@ -87,4 +87,4 @@ public PkuuchaStates(BossModule module) : base(module)
 }
 
 [ModuleInfo(BossModuleInfo.Maturity.Verified, Contributors = "Shinryin", GroupType = BossModuleInfo.GroupType.Hunt, GroupID = (uint)BossModuleInfo.HuntRank.A, NameID = 13443)]
-public class Pkuucha(WorldState ws, Actor primary) : SimpleBossModule(ws, primary);
+public class Pkuucha(WorldState ws, Actor primary) : SimpleBossModule(ws, primary);