Merge pull request #517 from FFXIV-CombatReborn/mergeWIP

code analyzer fix
FFXIV-CombatReborn · Dec 26, 2024 · c6bb1f8 · c6bb1f8
2 parents 57603d6 + 22ca61b
commit c6bb1f8
Showing 1 changed file with 10 additions and 8 deletions.
diff --git a/BossMod/Modules/Shadowbringers/Dungeon/D03QitanaRavel/D033Eros.cs b/BossMod/Modules/Shadowbringers/Dungeon/D03QitanaRavel/D033Eros.cs
@@ -81,10 +81,11 @@ public override void AddAIHints(int slot, Actor actor, PartyRolesConfig.Assignme
         var source = Sources(slot, actor).FirstOrDefault();
         if (source != default)
         {
-            var component = _aoe.ActiveAOEs(slot, actor);
-            var forbidden = new List<Func<WPos, float>>(component.Count());
-            foreach (var c in component)
-                forbidden.Add(ShapeDistance.Rect(c.Origin, Module.PrimaryActor.Rotation, 40, 0, 6));
+            Components.GenericAOEs.AOEInstance[] component = [.. _aoe.ActiveAOEs(slot, actor)];
+            var len = component.Length;
+            var forbidden = new List<Func<WPos, float>>(len);
+            for (var i = 0; i < len; ++i)
+                forbidden.Add(ShapeDistance.Rect(component[i].Origin, Module.PrimaryActor.Rotation, 40, 0, 6));
             if (forbidden.Count != 0)
                 hints.AddForbiddenZone(p => forbidden.Min(f => f(p)), source.Activation);
         }
@@ -102,10 +103,11 @@ public override void AddAIHints(int slot, Actor actor, PartyRolesConfig.Assignme
         var source = Sources(slot, actor).FirstOrDefault();
         if (source != default)
         {
-            var component = _aoe.ActiveAOEs(slot, actor);
-            var forbidden = new List<Func<WPos, float>>(component.Count());
-            foreach (var c in component)
-                forbidden.Add(ShapeDistance.Rect(c.Origin, new Angle(), 40, 40, 6));
+            Components.GenericAOEs.AOEInstance[] component = [.. _aoe.ActiveAOEs(slot, actor)];
+            var len = component.Length;
+            var forbidden = new List<Func<WPos, float>>(len);
+            for (var i = 0; i < len; ++i)
+                forbidden.Add(ShapeDistance.Rect(component[i].Origin, new Angle(), 40, 40, 6));
             if (forbidden.Count != 0)
                 hints.AddForbiddenZone(p => forbidden.Min(f => f(p)), source.Activation);
         }