Merge pull request #612 from FFXIV-CombatReborn/mergeWIP

code analyzer fix

BossMod/Modules/Global/DeepDungeon/FloorPathfind.cs

@@ -11,7 +11,7 @@ public enum Direction
 }
 
 // neat feature of deep dungeons - there is only one path from any room to any other room (no loops) and the grid is so small that brute forcing is basically free!
-internal class FloorPathfind(ReadOnlySpan<RoomFlags> Map)
+internal sealed class FloorPathfind(ReadOnlySpan<RoomFlags> Map)
 {
     public readonly RoomFlags[] Map = Map.ToArray();
 

BossMod/Modules/Global/DeepDungeon/LevelData.cs

@@ -1,46 +1,55 @@
 namespace BossMod.Global.DeepDungeon;
 
-public record class Floor<T>(uint DungeonId, uint Floorset, Tileset<T> RoomsA, Tileset<T> RoomsB)
+public sealed record class Floor<T>(uint DungeonId, uint Floorset, Tileset<T> RoomsA, Tileset<T> RoomsB)
 {
     public Floor<M> Map<M>(Func<T, M> Mapping) => new(DungeonId, Floorset, RoomsA.Map(Mapping), RoomsB.Map(Mapping));
 }
 
-public record class Tileset<T>(RoomData<T>[] Rooms)
+public sealed record class Tileset<T>
 {
+    private readonly RoomData<T>[] _rooms;
+
+    public Tileset(RoomData<T>[] rooms)
+    {
+        _rooms = rooms;
+    }
+
+    public IReadOnlyList<RoomData<T>> Rooms => _rooms;
+
     public Tileset<M> Map<M>(Func<T, M> Mapping)
     {
-        var len = Rooms.Length;
+        var len = _rooms.Length;
         var mappedRooms = new RoomData<M>[len];
         for (var i = 0; i < len; ++i)
         {
-            mappedRooms[i] = Rooms[i].Map(Mapping);
+            mappedRooms[i] = _rooms[i].Map(Mapping);
         }
         return new Tileset<M>(mappedRooms);
     }
 
-    public RoomData<T> this[int index] => Rooms[index];
+    public RoomData<T> this[int index] => _rooms[index];
 
     public override string ToString()
     {
         var sb = new StringBuilder();
         sb.Append("Tileset { Rooms = [");
-        var len = Rooms.Length;
+        var len = _rooms.Length;
         for (var i = 0; i < len; ++i)
         {
             if (i > 0)
             {
                 sb.Append(", ");
             }
-            sb.Append(Rooms[i].ToString());
+            sb.Append(_rooms[i].ToString());
         }
         sb.Append("] }");
         return sb.ToString();
     }
 }
 
-public record class RoomData<T>(T Center, T North, T South, T West, T East)
+public sealed record class RoomData<T>(T Center, T North, T South, T West, T East)
 {
     public RoomData<M> Map<M>(Func<T, M> F) => new(F(Center), F(North), F(South), F(West), F(East));
 }
 
-public record struct Wall(WPos Position, float Depth);
+public readonly record struct Wall(WPos Position, float Depth);

BossMod/Modules/Global/DeepDungeon/Minimap.cs

@@ -4,7 +4,7 @@
 
 namespace BossMod.Global.DeepDungeon;
 
-public record class Minimap(DeepDungeonState State, Angle PlayerRotation, int CurrentDestination)
+public sealed record class Minimap(DeepDungeonState State, Angle PlayerRotation, int CurrentDestination)
 {
     enum IconID : uint
     {