Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix idle teleporting from inside estate #179

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

oorzkws
Copy link

@oorzkws oorzkws commented Aug 17, 2024

Lifestream can be set to auto-enter estate and this would cause an infinite loop, entering the estate then teleporting back to the outside entrance.

Code notes:

I'm unsure what class name you would prefer here. I'm not sure shadowing the one used by FFXIVClientStructs is the best idea long-term.

Lifestream can be set to auto-enter estate and this breaks our previous behavior
@oorzkws
Copy link
Author

oorzkws commented Aug 17, 2024

P.S. Materia extraction errors when you change zones during. I don't know the task processing code well enough to PR a fix.

16:05:02.977 | ERR | [GatherBuddyReborn] Object reference not set to an instance of an object.
	   at GatherBuddy.AutoGather.AutoGather.<DoMateriaExtraction>b__109_2() in D:\Documents\GitHub\GatherBuddyReborn\GatherBuddy\AutoGather\AutoGather.Spiritbond.cs:line 48
	   at ECommons.Automation.LegacyTaskManager.TaskManager.<>c__DisplayClass37_0.<Enqueue>b__0() in D:\Documents\GitHub\GatherBuddyReborn\ECommons\ECommons\Automation\LegacyTaskManager\[email protected]:line 63
	   at ECommons.Automation.LegacyTaskManager.TaskManager.Tick(Object _) in D:\Documents\GitHub\GatherBuddyReborn\ECommons\ECommons\Automation\LegacyTaskManager\TaskManager.cs:line 141

@NostraThomas99 NostraThomas99 merged commit 335eb7a into FFXIV-CombatReborn:main Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants