Skip to content
This repository has been archived by the owner on Jul 3, 2024. It is now read-only.

Commit

Permalink
BRD Straight Shot Ready and Shadowbite Ready should now always be pri…
Browse files Browse the repository at this point in the history
…oritized over using other abilties that might ghost a ready charge due to Bards inabiltiy to hold more than one charge
  • Loading branch information
LTS-FFXIV committed May 29, 2024
1 parent c57e549 commit 3482b51
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions BasicRotations/Ranged/BRD_Default.cs
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,9 @@ protected override bool AttackAbility(IAction nextGCD, out IAction? act)
#region GCD Logic
protected override bool GeneralGCD(out IAction? act)
{
if (ShadowbitePvE.CanUse(out act)) return true;
if (StraightShotPvE.CanUse(out act)) return true;

if (IronJawsPvE.CanUse(out act)) return true;
if (IronJawsPvE.CanUse(out act, skipStatusProvideCheck: true) && (IronJawsPvE.Target.Target?.WillStatusEnd(30, true, IronJawsPvE.Setting.TargetStatusProvide ?? []) ?? false))
{
Expand All @@ -157,13 +160,11 @@ protected override bool GeneralGCD(out IAction? act)
if (Player.HasStatus(true, StatusID.RagingStrikes) && BarragePvE.Cooldown.IsCoolingDown) return true;
}

if (ShadowbitePvE.CanUse(out act)) return true;
if (QuickNockPvE.CanUse(out act)) return true;

if (WindbitePvE.CanUse(out act)) return true;
if (VenomousBitePvE.CanUse(out act)) return true;

if (StraightShotPvE.CanUse(out act)) return true;
if (HeavyShotPvE.CanUse(out act)) return true;

return base.GeneralGCD(out act);
Expand Down

3 comments on commit 3482b51

@Tykku
Copy link
Contributor

@Tykku Tykku commented on 3482b51 May 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change could allow dots to drop which is a dps loss, I would put them back tbh.

@LTS-FFXIV
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://xivanalysis.com/fflogs/a:GpCWT1wAnxDFRdrz/1/2 (.7% DOT downtime due to opening fight with auto attack instead of dot application), dot refresh window loose enough due to song changes and apex arrow usage that it never conflicts. Note issues with Raging strikes windows noted by xivanalysis are unrelated and exist with or without prioritization change. log identical to 6.5.9.49 in regards to dot uptime

@Tykku
Copy link
Contributor

@Tykku Tykku commented on 3482b51 May 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.