Skip to content
This repository has been archived by the owner on Nov 23, 2024. It is now read-only.

Commit

Permalink
Add checks to prevent redundant LightspeedPvE usage
Browse files Browse the repository at this point in the history
Enhanced the `AttackAbility` method in `AST_Default.cs` to include
conditions that ensure `Lightspeed` status is not active before
using `LightspeedPvE`. This prevents unnecessary usage of the
`LightspeedPvE` ability when the `Lightspeed` status is already
applied to the player.
  • Loading branch information
LTS-FFXIV committed Sep 22, 2024
1 parent c76a64b commit 21220e1
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 4 deletions.
12 changes: 9 additions & 3 deletions BasicRotations/Healer/AST_Default.cs
Original file line number Diff line number Diff line change
Expand Up @@ -179,18 +179,24 @@ protected override bool AttackAbility(IAction nextGCD, out IAction? act)
act = null;
if (BubbleProtec && Player.HasStatus(true, StatusID.CollectiveUnconscious_848)) return false;

if (InCombat && DivinationPvE.Cooldown.ElapsedAfter(115) && LightspeedPvE.CanUse(out act, usedUp: true)) return true;
if (!Player.HasStatus(true, StatusID.Lightspeed)
&& InCombat
&& DivinationPvE.Cooldown.ElapsedAfter(115)
&& LightspeedPvE.CanUse(out act, usedUp: true)) return true;

if (IsBurst && !IsMoving
&& DivinationPvE.CanUse(out act)) return true;

if (AstralDrawPvE.CanUse(out act, usedUp: IsBurst)) return true;

if ((InBurstStatus || DivinationPvE.Cooldown.ElapsedAfter(115)) && InCombat && LightspeedPvE.CanUse(out act, usedUp: true)) return true;
if (!Player.HasStatus(true, StatusID.Lightspeed)
&& (InBurstStatus || DivinationPvE.Cooldown.ElapsedAfter(115))
&& InCombat
&& LightspeedPvE.CanUse(out act, usedUp: true)) return true;

if (InCombat)
{
if (IsMoving && LightspeedPvE.CanUse(out act, usedUp: LightspeedMove)) return true;
if (!Player.HasStatus(true, StatusID.Lightspeed) && IsMoving && LightspeedPvE.CanUse(out act, usedUp: LightspeedMove)) return true;

if (!IsMoving)
{
Expand Down
2 changes: 1 addition & 1 deletion BasicRotations/RebornRotations.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
<Compile Include="Duty\EmanationDefault" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="RotationSolverReborn.Basic" Version="7.0.5.114" />
<PackageReference Include="RotationSolverReborn.Basic" Version="7.0.5.115" />
</ItemGroup>
<ItemGroup>
<Reference Include="Dalamud">
Expand Down

0 comments on commit 21220e1

Please sign in to comment.