This repository has been archived by the owner on Nov 23, 2024. It is now read-only.
Refactor status checks and ability logic in VPR and BRD #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored status checks in `VPR_Default.cs` by replacing `StatusID.Reawakened` with `StatusID.ReadyToReawaken` in multiple conditionals, affecting abilities like `UncoiledFuryPvE` and `SerpentsIrePvE`. Expanded `InBurstStatus` logic in `BRD_Default.cs` to include additional conditions based on player level and status effects such as `BattleVoice` and `RadiantFinale`, making the burst status check more comprehensive. Removed BRD Experemental pot usage. Updated logic for using `RadiantFinalePvE` and `BattleVoicePvE` in `BRD_Default.cs` to include more detailed conditions considering cooldowns and player status effects. Modified the `GeneralGCD` method in `BRD_Default.cs` to check for the `BattleVoice` status instead of `RagingStrikes` when determining if `IronJawsPvE` should be used.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored status checks in
VPR_Default.csby replacingStatusID.ReawakenedwithStatusID.ReadyToReawakenin multiple conditionals, affecting abilities likeUncoiledFuryPvEandSerpentsIrePvE.Expanded
InBurstStatuslogic inBRD_Default.csto include additional conditions based on player level and status effects such asBattleVoiceandRadiantFinale, making the burst status check more comprehensive.Removed BRD Experemental pot usage.
Updated logic for using
RadiantFinalePvEandBattleVoicePvEinBRD_Default.csto include more detailed conditions considering cooldowns and player status effects.Modified the
GeneralGCDmethod inBRD_Default.csto check for theBattleVoicestatus instead ofRagingStrikeswhen determining ifIronJawsPvEshould be used.