Skip to content
This repository has been archived by the owner on Nov 23, 2024. It is now read-only.

MCH Low Level HotShot/Drill Fix #212

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Conversation

Four-amer
Copy link
Contributor

Level 62 machinist now uses Reassemble on Drill instead of HotShot and also shouldn't wait for HotShot to use Drill, haven't tested if this approach hurts rotation on higher levels

Level 62 machinist now uses Reassemble on Drill instead of HotShot and also shouldn't wait for HotShot
to use Drill
@Karaha-Baruha
Copy link
Contributor

Level 62 machinist now uses Reassemble on Drill instead of HotShot and also shouldn't wait for HotShot to use Drill, haven't tested if this approach hurts rotation on higher levels

It shouldn't, as Drill has the same potency as Air Anchor

@Four-amer
Copy link
Contributor Author

Four-amer commented Sep 10, 2024

Level 62 machinist now uses Reassemble on Drill instead of HotShot and also shouldn't wait for HotShot to use Drill, haven't tested if this approach hurts rotation on higher levels

It shouldn't, as Drill has the same potency as Air Anchor

That's true, however I'm referring to a way i coded the low level fix in. This is my first time trying to contribute and I'm still trying to figure out stuff, so this solution could have unintended consequences on rotation when AirAnchor or Drill stacking is unlocked. And i can't test it myself since my MCH is only Lv 62.

@Karaha-Baruha
Copy link
Contributor

Level 62 machinist now uses Reassemble on Drill instead of HotShot and also shouldn't wait for HotShot to use Drill, haven't tested if this approach hurts rotation on higher levels

It shouldn't, as Drill has the same potency as Air Anchor

That's true, however I'm referring to a way i coded the low level fix in. This is my first time trying to contribute and I'm still trying to figure out stuff, so this solution could have unintended consequences on rotation when AirAnchor or Drill stacking is unlocked. And i can't test it myself since my MCH is only Lv 62.

Going to pull this down and SSS test it at 70-80-90-100. Stand by

@LTS-FFXIV LTS-FFXIV added the under review were looking at it label Sep 11, 2024
@LTS-FFXIV LTS-FFXIV merged commit 5b0e957 into FFXIV-CombatReborn:main Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
under review were looking at it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants