This repository has been archived by the owner on Nov 23, 2024. It is now read-only.
Remove AST_Archive and update GeneralGCD logic #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Significant refactoring and cleanup in the `AST_Archive` namespace: - Removed `DefaultRotations.Healer` namespace and `AST_Beta` class. - Added new logic for `EmergencyAbility`, `DefenseSingleAbility`, `HealSingleAbility`, `HealAreaAbility`, and `GeneralGCD` methods. - Introduced new rotation descriptions for several abilities. - Added new conditions and checks based on player status and combat state. Removed `zAST_BETA` class from `DefaultRotations.Healer` namespace: - Deleted the class and all associated methods and properties. Updated property defaults: - `MotifSwiftCastSwift` default changed to `true`. - `MotifSwiftCast` default changed to `CanvasFlags.Weapon`. Updated `GeneralGCD` method: - Removed `skipCastingCheck: true` parameter from various method calls to ensure casting checks are performed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Significant refactoring and cleanup in the
AST_Archivenamespace:DefaultRotations.Healernamespace andAST_Betaclass.EmergencyAbility,DefenseSingleAbility,HealSingleAbility,HealAreaAbility, andGeneralGCDmethods.Removed
zAST_BETAclass fromDefaultRotations.Healernamespace:Updated property defaults for testing rotation:
MotifSwiftCastSwiftdefault changed totrue.MotifSwiftCastdefault changed toCanvasFlags.Weapon.Updated
GeneralGCDmethod:skipCastingCheck: trueparameter from various method calls to ensure casting checks are performed.