This repository has been archived by the owner on Nov 23, 2024. It is now read-only.
Dancer Optimalizations #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shouldn't use abilities that their animation lock can drift dancing right before dance and during it, Just like Curing Waltz Sometimes it used FanDance II or FanDance when FanDance III was available, now it doesn't. However it hard to test since it happens rarely but i didn't notice a single instance of it happening for 2 hours so its probably working as intented The overcapping mechanic for feathers now uses feathers before nextGCD that can generate it, instead of instantly when it hits 4, also moved the storing feathers mechanic to when the player hits level anough for devilment instead of tech step. It seems that the code that prevented using standard step when technical step cd is less that time required to do the dance didn't work properly. Fixed that
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Won't use abilities right before dancing or while dancing because their animation lock might delay the dance, happened to me with curing waltz.
Sometimes it used FanDance II or FanDance when FanDance III was available, now it shouldn't.
However it's hard to test since it happens rarely, but i didn't notice a single instance of it happening for 2 hours so its probably working as intented now.
The anti overcapping mechanic for feathers now uses feathers before nextGCD that can generate it, instead of instantly when it hits 4, also moved the storing feathers mechanic to when the player hits level high enough for devilment instead of tech step.
It seems that the code that prevents using standard step when it would delay tech step didn't work properly. Fixed that
Tested on Dancer Lv 72 and 60.
Also FYI my discord username is Fouramer .
Happy to contribute!