Skip to content

Commit

Permalink
Merge pull request #147 from FFXIV-CombatReborn/beauty-wicked-wiles
Browse files Browse the repository at this point in the history
RS.Basic changes to support more duty actions
  • Loading branch information
LTS-FFXIV authored May 13, 2024
2 parents 1f3ca73 + f8f44b5 commit 00e6dff
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 17 deletions.
12 changes: 0 additions & 12 deletions RotationSolver.Basic/Rotations/Duties/DutyRotation.cs
Original file line number Diff line number Diff line change
Expand Up @@ -52,18 +52,6 @@ public virtual bool DefenseAreaGCD(out IAction? act)

#region Ability

static partial void ModifyVrilPvE(ref ActionSetting setting)
{
setting.StatusFromSelf = true;
setting.TargetStatusProvide = [StatusID.Vril];
}

static partial void ModifyVrilPvE_9345(ref ActionSetting setting)
{
setting.StatusFromSelf = true;
setting.TargetStatusProvide = [StatusID.Vril];
}

public virtual bool InterruptAbility(IAction nextGCD, out IAction? act)
{
act = null; return false;
Expand Down
25 changes: 25 additions & 0 deletions RotationSolver.Basic/Rotations/Duties/EmanationRotation.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@

namespace RotationSolver.Basic.Rotations.Duties;

/// <summary>
/// The variant action.
/// </summary>
[DutyTerritory(263, 264)] //TODO: the variant territory ids!
public abstract class EmanationRotation : DutyRotation
{
}

partial class DutyRotation
{
static partial void ModifyVrilPvE(ref ActionSetting setting)
{
setting.StatusFromSelf = true;
setting.TargetStatusProvide = [StatusID.Vril];
}

static partial void ModifyVrilPvE_9345(ref ActionSetting setting)
{
setting.StatusFromSelf = true;
setting.TargetStatusProvide = [StatusID.Vril];
}
}
6 changes: 1 addition & 5 deletions RotationSolver.Basic/Rotations/Duties/VariantRotation.cs
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@

namespace RotationSolver.Basic.Rotations.Duties;
namespace RotationSolver.Basic.Rotations.Duties;

/// <summary>
/// The variant action.
/// </summary>
[DutyTerritory(1069, 1075, 1076, 1137, 1176)] //TODO: the variant territory ids!
public abstract class VariantRotation : DutyRotation
{
Expand Down

0 comments on commit 00e6dff

Please sign in to comment.