Skip to content

Commit

Permalink
Update UI descriptions and percentage handling in config
Browse files Browse the repository at this point in the history
Updated the `Configs` class to clarify the `_dispelAll` field's UI description, specifying it cleanses all dispellable debuffs. Adjusted the `RotationConfigWindow` class to handle user inputted values better
  • Loading branch information
LTS-FFXIV committed Jan 20, 2025
1 parent 882c93d commit 38e311d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion RotationSolver.Basic/Configuration/Configs.cs
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ public const string
[ConditionBool, UI("Stop casting if the target dies.", Filter = Extra)]
private static readonly bool _useStopCasting = false;

[ConditionBool, UI("Cleanse all dispellable debuffs.",
[ConditionBool, UI("Cleanse all dispellable debuffs (not just those in the status list).",
Filter = AutoActionUsage, Section = 3,
PvEFilter = JobFilterType.Dispel, PvPFilter = JobFilterType.NoJob)]
private static readonly bool _dispelAll = false;
Expand Down
5 changes: 3 additions & 2 deletions RotationSolver/UI/RotationConfigWindow.cs
Original file line number Diff line number Diff line change
Expand Up @@ -1463,9 +1463,10 @@ private static void DrawRotationConfiguration()

if (f.UnitType == ConfigUnitType.Percent)
{
if (ImGui.SliderFloat(name, ref val, f.Min, f.Max, $"{val * 100:F1}{f.UnitType.ToSymbol()}"))
float displayValue = val * 100;
if (ImGui.SliderFloat(name, ref displayValue, f.Min * 100, f.Max * 100, $"{displayValue:F1}{f.UnitType.ToSymbol()}"))
{
config.Value = val.ToString();
config.Value = (displayValue / 100).ToString();
}
}
else
Expand Down

0 comments on commit 38e311d

Please sign in to comment.