Fixed bool toggles in settings

FFXIV-CombatReborn · Apr 7, 2024 · 40a9b39 · 40a9b39
1 parent e29b64a
commit 40a9b39
Showing 1 changed file with 12 additions and 3 deletions.
diff --git a/RotationSolver/Commands/RSCommands_OtherCommand.cs b/RotationSolver/Commands/RSCommands_OtherCommand.cs
@@ -47,7 +47,9 @@ private static void DoSettingCommand(string str)
         }
         var value = strs.LastOrDefault();
 
-        foreach (var property in typeof(Configs).GetRuntimeProperties())
+
+        foreach (var property in typeof(Configs).GetRuntimeProperties()
+            .Where(p => p.GetMethod?.IsPublic ?? false))
         {
             if (!str.StartsWith(property.Name, StringComparison.OrdinalIgnoreCase)) continue;
 
@@ -58,11 +60,18 @@ private static void DoSettingCommand(string str)
                 type = typeof(bool);
             }
 
-            var v = Convert.ChangeType(value, type);
+            object v;
+            try { v = Convert.ChangeType(value, type); }
+            catch { v = null; }
 
             if (v == null && type == typeof(bool))
             {
-                v = !(bool)property.GetValue(Service.Config)!;
+                var config = property.GetValue(Service.Config);
+                if (config is ConditionBoolean relay)
+                {
+                    relay.Value = !relay.Value;
+                    v = relay.Value;
+                }
             }
 
             if (property.PropertyType == typeof(ConditionBoolean))