-
Notifications
You must be signed in to change notification settings - Fork 47
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactor and enhance rotation logic and configurations
Refactored SCH, SGE, and WHM rotation logic for better readability and maintainability. Updated `SCH_Default.cs` and `SGE_Default.cs` to iterate over party members and tanks for specific actions. Simplified and refactored methods in `SGE_Default.cs` to remove LINQ. Updated `ECommons` subproject commit. Removed `IsLastAbilityUsable` and `IsFirstAbilityUsable` checks in `BaseAction.cs`. Added new configuration options in `Configs.cs` for raising players and adjusted `_action4head` value. Updated `DataCenter.cs` with XML documentation comments and adjusted `CalculatedActionAhead`. Refactored `StatusHelper` and `TargetFilter` methods to use explicit loops instead of LINQ. Improved `CustomRotation` logic with additional checks and conditions. Commented out `UseLimitBreak` method in `CustomRotation_GCD.cs`. Added null checks and early returns in `CustomRotation` methods. Cleaned up debug text in `RotationConfigWindow`. Simplified `RemoveExpiredVfxData` method in `MajorUpdater`. Enhanced `TargetUpdater` with explicit loops, new configuration checks, and improved logic for determining valid raise targets.
- Loading branch information
Showing
14 changed files
with
295 additions
and
232 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule ECommons
updated
27 files
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.