Merge pull request #98 from FFXIV-CombatReborn/api-level-attribute

Added in APILevel check
FFXIV-CombatReborn · Apr 16, 2024 · efa109a · efa109a
2 parents 0c1d6de + d723c62
commit efa109a
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/RotationSolver/Updaters/RotationUpdater.cs b/RotationSolver/Updaters/RotationUpdater.cs
@@ -198,11 +198,17 @@ private static CustomRotationGroup[] LoadCustomRotationGroup(List<Assembly> asse
             foreach (var type in TryGetTypes(assembly))
             {
                 if (type.GetInterfaces().Contains(typeof(ICustomRotation))
-                    && !type.IsAbstract && !type.IsInterface && type.GetConstructor([]) != null)
-                    //&& type.GetCustomAttribute<ApiAttribute>()?.ApiVersion == Service.ApiVersion) //TODO: Check for API version
+                    && !type.IsAbstract && !type.IsInterface && type.GetConstructor([]) != null
+                    && type.GetCustomAttribute<ApiAttribute>()?.ApiVersion == Service.ApiVersion)
                 {
                     rotationList.Add(type);
                 }
+                //else if (type.GetInterfaces().Contains(typeof(ICustomRotation))
+                //    && !type.IsAbstract && !type.IsInterface && type.GetConstructor([]) != null)
+                //{
+                //    var name = type.GetCustomAttribute<RotationAttribute>()?.Name ?? "Unknown";
+                //    Svc.Chat.PrintError($"Failed to load rotation {name} from assembly {assembly}");
+                //}
             }
         }