Refactor and improve performance and readability #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated ECommons subproject commit. Changed visibility of GeneralCheck method in ActionTargetInfo.cs. Updated descriptions and removed internalAttackTargetCount in Configs.cs. Removed dead target checks in DataCenter.cs. Improved CanProvoke and IsAlive methods in ObjectHelper.cs. Added new enum values in UiString.cs. Enhanced AddOneCondition method in ConditionDrawer.cs. Refactored CooldownWindow.cs, CtrlWindow.cs, NextActionWindow.cs, and RotationConfigWindow.cs for better readability and performance. Simplified font pointer check in FontManager.cs and tooltip logic in ImguiTooltips.cs. Improved SearchableCollection.cs performance and readability. Introduced static HttpClient instance and improved GitHub API request handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated ECommons subproject commit. Changed visibility of GeneralCheck method in ActionTargetInfo.cs. Updated descriptions and removed internalAttackTargetCount in Configs.cs. Removed dead target checks in DataCenter.cs. Improved CanProvoke and IsAlive methods in ObjectHelper.cs. Added new enum values in UiString.cs. Enhanced AddOneCondition method in ConditionDrawer.cs. Refactored CooldownWindow.cs, CtrlWindow.cs, NextActionWindow.cs, and RotationConfigWindow.cs for better readability and performance. Simplified font pointer check in FontManager.cs and tooltip logic in ImguiTooltips.cs. Improved SearchableCollection.cs performance and readability. Introduced static HttpClient instance and improved GitHub API request handling.