Ignore Target for Self-Targeted Area Buffs #422
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a bug that I and a couple other people could reproduce while playing as Pictomancer, where the skill would get stuck loop casting-and-cancelling itself until you were either outside the boss' target ring or behind their model.
Starry Muse is a Self-Targeted Area Buff and as such the skill's range is 0 from what I understood. When RSR calculates if the player's target is valid for that skill, it disregards if it's a self-targeted action and thus calculates the distance between player and boss against the skill's range.
When you're inside the boss' ring, your distance from it becomes negative aka "below 0" and then since RSR is considering the hostile target instead of yourself, Starry Muse becomes invalid.
The real tricky part, which I fully admit I don't understand, is why RSR casts before canceling it and why some people cannot reproduce it. Regardless, I don't think there's a reason for a self-targeted area buff to consider the boss' distance relative to the player or the skill range.