Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Target for Self-Targeted Area Buffs #422

Conversation

AcePetrucci
Copy link
Contributor

Description

This fixes a bug that I and a couple other people could reproduce while playing as Pictomancer, where the skill would get stuck loop casting-and-cancelling itself until you were either outside the boss' target ring or behind their model.

Starry Muse is a Self-Targeted Area Buff and as such the skill's range is 0 from what I understood. When RSR calculates if the player's target is valid for that skill, it disregards if it's a self-targeted action and thus calculates the distance between player and boss against the skill's range.
When you're inside the boss' ring, your distance from it becomes negative aka "below 0" and then since RSR is considering the hostile target instead of yourself, Starry Muse becomes invalid.

The real tricky part, which I fully admit I don't understand, is why RSR casts before canceling it and why some people cannot reproduce it. Regardless, I don't think there's a reason for a self-targeted area buff to consider the boss' distance relative to the player or the skill range.

@LTS-FFXIV LTS-FFXIV merged commit badf6f3 into FFXIV-CombatReborn:main Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants