Update ECommons submodule and refactor Configs class #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated ECommons submodule to commit b39bbc68ff7ee632d3121388e6f4e4aad6753dcd. Removed several configuration options from the Configs class: - _changeTargetForFate - _useTasksForOverlay - _onlyHotOnTanks - _targetFatePriority Replaced ConditionBool attribute with JobConfig for: - _interruptibleMoreCheck - _raisePlayerByCasting - _raisePlayerBySwift - _raiseBrinkOfDeath Changed PvEFilter for _raisePlayerBySwift to JobFilterType.Raise. Removed condition checks in DataCenter.cs and ObjectHelper.cs. Removed VPR job condition checks in CustomRotation_Ability.cs for JobRole.Melee. Added feature in CheckBoxSearch.cs to draw job icon if IsJob is true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated ECommons submodule to commit b39bbc68ff7ee632d3121388e6f4e4aad6753dcd. Removed several configuration options from the Configs class: