Guren shall be used when 2 or more targets #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Read Balance before you write code, kids* Balance: 'Guren is a gain starting on two targets' If you manually overrode this in Actions -> oGCD-Attack -> Guren -> How many targets from 1 to 2 already, you can ignore this update. If the settings above was 1 for you by default, and your SAM rotation was using Guren instead of Senei at Level 100 when hitting single target, do 'Reset plugin data and reload', then 1 shall become 2 automatically. And sennei shall be used correctly on single target. If this update affects your own code for using Guren at lower level, for example uww etc, use this instead: if (HissatsuGurenPvE.CanUse(out act, skipAoeCheck: !HissatsuSeneiPvE.EnoughLevel)) return true;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read Balance before you write code, kids
Balance: 'Guren is a gain starting on two targets'
If you manually overrode this in Actions -> oGCD-Attack -> Guren -> How many targets from 1 to 2 already, you can ignore this update. If the settings above was 1 for you by default, and your SAM rotation was using Guren instead of Senei at Level 100 when hitting single target, do 'Reset plugin data and reload', then 1 shall become 2 automatically. And sennei shall be used correctly on single target. If this update affects your own code for using Guren at lower level, for example uww etc, use this instead: if (HissatsuGurenPvE.CanUse(out act, skipAoeCheck: !HissatsuSeneiPvE.EnoughLevel)) return true;