Update ECommons submodule and add null checks to prevent bricking due to statuses without names #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to statuses without names Updated the ECommons submodule commit to `71ee09f7cc2230a73503b945422760da1368405c`. Added `System.Linq` to `using` directives in `DataCenter.cs`. Modified `DispelTarget` property in `DataCenter` class to include null checks for statuses in `StatusList` before calling `StatusHelper` methods (`CanDispel` and `IsDangerous`). Added null checks in `IsPriority`, `IsDangerous`, and `CanDispel` methods in `StatusHelper.cs` to ensure the `status` parameter is not null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ECommons submodule and add null checks to prevent bricking due to statuses without names
Updated the ECommons submodule commit to
71ee09f7cc2230a73503b945422760da1368405c. AddedSystem.Linqtousingdirectives inDataCenter.cs. ModifiedDispelTargetproperty inDataCenterclass to include null checks for statuses inStatusListbefore callingStatusHelpermethods (CanDispelandIsDangerous). Added null checks inIsPriority,IsDangerous, andCanDispelmethods inStatusHelper.csto ensure thestatusparameter is not null.